-
Notifications
You must be signed in to change notification settings - Fork 55
Avies PR #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Avies PR #1294
Conversation
JordanSantiagoYT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it all seems fine, although some v-slice code is still left over
| /* | ||
| * WHAT THE FUCK IS THIS?? | ||
| * YOU SHOULD MAKE THIS FUNCTION ON A SEPARATE SCRIPT FILE | ||
| * ALSO WHY THE FUCK IS THE GAME HARDCODED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avie you should realize every engine does this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should realize that you should popularize NOT doing the same shit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i'm convinced that you have gone absolutely braindead
if you want all of this, do it yourself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want all of this, do it yourself.
planning to when i have TIME
Like what? The stuff in strumnote? |
so many other engines has the same v-slice code on it, it's more organized anyway. |
it's useless now
Just removing unnecessary V-Slice stuff from this PR (and possibly other things)